Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix lmr max speed prefill #9973

Merged
merged 1 commit into from
Dec 5, 2024
Merged

front: fix lmr max speed prefill #9973

merged 1 commit into from
Dec 5, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Dec 5, 2024

fix #9972

@Wadjetz Wadjetz added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules labels Dec 5, 2024
@Wadjetz Wadjetz self-assigned this Dec 5, 2024
@Wadjetz Wadjetz marked this pull request as ready for review December 5, 2024 15:37
@Wadjetz Wadjetz requested a review from a team as a code owner December 5, 2024 15:37
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (7a0728b) to head (4bd6b19).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9973      +/-   ##
==========================================
- Coverage   79.87%   79.86%   -0.01%     
==========================================
  Files        1047     1047              
  Lines      105152   105152              
  Branches      756      756              
==========================================
- Hits        83988    83982       -6     
- Misses      21123    21129       +6     
  Partials       41       41
Flag Coverage Δ
editoast 73.38% <ø> (-0.02%) ⬇️
front 89.35% <100.00%> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus mentioned this pull request Dec 5, 2024
Closed
SharglutDev
SharglutDev approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, thank you for the quick fix :)

Akctarus
Akctarus approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM !

@Akctarus Akctarus enabled auto-merge December 5, 2024 15:54
@Wadjetz
front: fix lmr max speed prefill
4bd6b19 
Signed-off-by: Egor Berezovskiy <egor@berezify.fr>
@Wadjetz Wadjetz force-pushed the ebe/front/lmr/fix-max-speed-prefill branch from 2125f66 to 4bd6b19 Compare December 5, 2024 16:00
@Akctarus Akctarus added this pull request to the merge queue Dec 5, 2024
Merged via the queue into dev with commit e114f8a Dec 5, 2024
27 checks passed
@Akctarus Akctarus deleted the ebe/front/lmr/fix-max-speed-prefill branch December 5, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharglutDev SharglutDev SharglutDev approved these changes

@Akctarus Akctarus Akctarus approved these changes

Assignees

@Wadjetz Wadjetz

Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: max speed in the consist is in m/s
4 participants
@Wadjetz @codecov-commenter @Akctarus @SharglutDev